Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for unit testing #34

Open
4 tasks
nic-hartley opened this issue Feb 3, 2023 · 0 comments
Open
4 tasks

Refactor for unit testing #34

nic-hartley opened this issue Feb 3, 2023 · 0 comments
Labels
k: refactor reorganization of existing code without function changes k: repo the repository's organization overall p: repo all crates, or the repo itself

Comments

@nic-hartley
Copy link
Owner

nic-hartley commented Feb 3, 2023 •
edited
Loading

During my first pass at writing tests, I didn't bother refactoring, partly because this GUI system is... kinda complex and I need to refactor it cleaner. Specifically, I need a nicer way to write UI unit tests that doens't depend too much on exact, charcater-by-character looks. Or I need to stabilize the UI enough to confidently write tests asserting exact, character-by-character looks.

  • Decide how UI testing can work
  • Test UI accordingly
  • Bump code coverage back up to 90%
  • Add code coverage back to CI with cargo-tarpaulin or similar
@nic-hartley nic-hartley mentioned this issue Feb 3, 2023
Merged
10 tasks
@nic-hartley nic-hartley added p: repo all crates, or the repo itself k: repo the repository's organization overall k: refactor reorganization of existing code without function changes labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
k: refactor reorganization of existing code without function changes k: repo the repository's organization overall p: repo all crates, or the repo itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nic-hartley