Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalConfiguration custom name in helm chart #6679

Open
frantsao opened this issue Oct 17, 2024 · 2 comments · May be fixed by #6680
Open

GlobalConfiguration custom name in helm chart #6679

frantsao opened this issue Oct 17, 2024 · 2 comments · May be fixed by #6680
Labels
proposal An issue that proposes a feature request
Milestone
v4.1.0

Comments

@frantsao
Copy link

frantsao commented Oct 17, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
This issue is related to a situation that occurs when we want to provision the ingress controller using a helm chart but the GlobalConfiguration resource is previously created using a manifest (i.e. operating with Terraform).

Describe the solution you'd like
I would like to provide a custom name to helm chart to configure the ingress controller with the GlobalConfiguration previously created, in order to achieve the prerrequisites.

Describe alternatives you've considered
The easiest alterantive that doesn't break my work flow has been forking the chart and adding the parameter by myself (so, PR is on the way ;-)).

Additional context
N/A
@frantsao frantsao added the proposal An issue that proposes a feature request label Oct 17, 2024
@github-actions GitHub Actions
Copy link

Hi @frantsao thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@frantsao frantsao linked a pull request Oct 17, 2024 that will close this issue
Open
6 tasks
frantsao added a commit to frantsao/kubernetes-ingress that referenced this issue Oct 17, 2024
@frantsao
Helm: add globalConfigurationCustomName parameter
812e7ef 
Add globalConfigurationCustomName parameter to controller
configuration in helm chart (nginx#6679)
@pdabelf5 pdabelf5 added needs triage An issue that needs to be triaged ready for refinement An issue that was triaged and it is ready to be refined and removed needs triage An issue that needs to be triaged labels Oct 21, 2024
@j1m-ryan
Copy link

Hi @frantsao, thanks for working on this.

We would like this parameter to be in the globalConfiguration object in the helm chart.

frantsao added a commit to frantsao/kubernetes-ingress that referenced this issue Dec 12, 2024
@frantsao
Helm: add globalConfigurationCustomName parameter
8490da9 
Extend globalConfiguration customName functionality
when gc create true (nginx#6679)
frantsao added a commit to frantsao/kubernetes-ingress that referenced this issue Dec 12, 2024
@frantsao
Helm: add globalConfigurationCustomName parameter
f8681b7 
 Fix documentation in values.yaml (nginx#6679)
@lucacome lucacome moved this to Todo ☑ in NGINX Ingress Controller Jan 15, 2025
@shaun-nx shaun-nx removed the ready for refinement An issue that was triaged and it is ready to be refined label Jan 21, 2025
@shaun-nx shaun-nx moved this from Todo ☑ to Prioritized backlog in NGINX Ingress Controller Jan 21, 2025
@shaun-nx shaun-nx linked a pull request Jan 21, 2025 that will close this issue
#6679 add globalConfigurationCustomName parameter #6680
Open
6 tasks
@shaun-nx shaun-nx added this to the v4.1.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal An issue that proposes a feature request
Projects
NGINX Ingress Controller
Status: Prioritized backlog
Milestone
v4.1.0
Development

Successfully merging a pull request may close this issue.

#6679 add globalConfigurationCustomName parameter frantsao/kubernetes-ingress
4 participants
@frantsao @j1m-ryan @shaun-nx @pdabelf5