Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing $overrides service autoload #134

Open
nfroidure opened this issue Nov 18, 2024 · 0 comments
Open

Consider allowing $overrides service autoload #134

nfroidure opened this issue Nov 18, 2024 · 0 comments
Assignees

Comments

@nfroidure
Copy link
Owner

Currently, the service is a constant (and is forced to be a constant) https://github.com/nfroidure/knifecycle/blob/main/src/index.ts#L283

The reason for it is that loading a service could lead to different results overtime which is not a good thing.

That said, we could allow to change the $overrides mapping (and autoload it) by checking that the mapping were not used yet and refuse to change it by another mapping that don't fit the previously mapped service names.

@nfroidure nfroidure self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant