-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nf-core module for immunedeconv and add to pipeline #368
Comments
HI @grst I created a POC for this module: #390
I wanted to get your input on whether if you think this is something that should be solved by the module, by adding a section that validate the columns; and adding a warning telling the user to make sure that the data is TPM transformed. |
Thanks! I wouldn't do any transformations of the data inside the module, but having checks can't harm.
IIRC it could have any number of string columns, they can be set by a pipeline parameter. A completely different approach would be to not make a separate module but go with a custom quarto report instead? Not sure if that would be acceptable for this pipeline... |
@grst I added a check for log and TPM transformation, it won't crash the execution, but it will warn the user if the data seems to be log transformed, or if it doesn't look TPM transformed. PR for this: #390 The one thing that I'm seeing is that, even though the module works for the immunedeconv test data, it doesn't work for none of the matrices in our test data, they all raise this error:
This doesn't seem to be an issue with the script, but it seems to be an issue with the actual data. Do you know what this may be? |
I suspect that the data uses ENSG identifiers, while immunedeconv requires gene symbols. In the differentialabundance pipeline, it's possible to specify a column name that contains gene symbols when ENGS are the primary identifiers. I see several options (1) Document that the module requires gene symbols and leave it to the pipeline to provide them I'd lean to (1) or maybe (2) but I'll leave it for you to decide what makes most sense also from the perspective of integrating it into the pipeline. |
Pipeline PR: #390 |
immunedeconv supports cell-type deconvolution of bulk RNA-seq data given predefined sets of immune cell signatures.
The text was updated successfully, but these errors were encountered: