Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom config for seadragon cluster of MD Anderson Cancer Center #830

Closed
wants to merge 2 commits into from

Conversation

jiawku
Copy link

@jiawku jiawku commented Jan 17, 2025


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@jiawku jiawku closed this Jan 18, 2025
@jfy133
Copy link
Member

jfy133 commented Jan 18, 2025

@jiawku any problems I can help weith? I was about to review this

@jiawku
Copy link
Author

jiawku commented Jan 18, 2025

@jiawku any problems I can help weith? I was about to review this

Hi James,

Thank you so much for offering your help. I encountered an issue with the per-commit test. It failed due to a missing newline in the CODEOWNERS file. To resolve this, I've created a new commit, closed the original pull request, and opened a new one here: #831.

However, the Precommit test is still showing another error that I don't understand:

prettier.................................................................Failed
- hook id: prettier
- files were modified by this hook

I would greatly appreciate it if you could review the PR and merge it. This is my first pull request to a public repository, so please let me know if anything is unclear or requires further clarification.

@jfy133
Copy link
Member

jfy133 commented Jan 18, 2025

Ok! No problem

I'm on the way to the airport, will look properly there but I've otherwise triggered the checks

Note you do not need to close the PR if there is an error - a pull request is not static. You can make edits to the branch and the PR will update automatically

@jiawku
Copy link
Author

jiawku commented Jan 18, 2025

Got you. Thanks James. Have a good trip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants