Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed matrix.test_name in linting and missing features from template 3.0.2 #179

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fixed matrix.test_name in linting and missing features from template 3.0.2 #179

merged 4 commits into from
Nov 5, 2024

Conversation

Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Oct 25, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

I incorrectly incorporated the test names in the GitHub CI after the nf-core template update. As a result, only the test profile was running repeatedly. This update should fix the issue and ensure the correct tests are executed.

In addition, config test missed to incorporate resourceLimits feature in test profiles (see 'Whats new 3.0.0').

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aa42f95

+| ✅ 209 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-25 10:01:38

@github-actions GitHub Actions
Copy link

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2bccce1

+| ✅ 209 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-25 09:21:56

@Daniel-VM Daniel-VM changed the title fixed matrix.test_name in linting fixed matrix.test_name in linting and missing features from template 3.0.2 Oct 25, 2024
@Daniel-VM Daniel-VM mentioned this pull request Oct 25, 2024
Merged
10 tasks
@Daniel-VM Daniel-VM marked this pull request as ready for review October 25, 2024 13:58
@Daniel-VM
Copy link
Contributor Author

The DFAST test is failing due to external factors: maintenance period. See details at https://www.ddbj.nig.ac.jp/news/en/2024-10-30_2-e.html

@Daniel-VM Daniel-VM merged commit 02bf3dd into nf-core:dev Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-VM @mashehu @sateeshperi