Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bakta to v1.8.2 #103

Merged
merged 1 commit into from
Oct 26, 2023
Merged

update bakta to v1.8.2 #103

merged 1 commit into from
Oct 26, 2023

Conversation

Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Oct 26, 2023

PR description

Just an update of Bakta version in BAKTA_DBDOWNLOAD_RUN:BAKTA_BAKTADBDOWNLOAD().

Closes #102

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit af842a6

+| ✅ 159 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-26 12:37:40

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, does that mean that Bakta could be activated in any of the test*.configs? (It isnt active in any, is it?)

@Daniel-VM
Copy link
Contributor Author

Daniel-VM commented Oct 26, 2023

Sorry, I didn't mean that bakta can be tested with conf/test*.config. I simply updated its version in BAKTA_DBDOWNLOAD_RUN:BAKTA_BAKTADBDOWNLOAD().

@Daniel-VM Daniel-VM merged commit 94058bd into nf-core:dev Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants