Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the nf-core/Ampliseq usage sections Metadata and Sample input to remove the dashes (-) as allowed characters in sampleIDs #821

Open
tremblayemilie opened this issue Jan 8, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@tremblayemilie
Copy link

Description of the bug

Hello, as I reported into the #ampliseq Slack thread here, https://nfcore.slack.com/archives/CEA7TBJGJ/p1736280240867139, the nf-core/ampliseq usage page is misleading naive users like me. It is no longer possible to use dashes (-) in sample IDs but, under the metadata section, we can read this: 'Sample identifiers should be 36 characters long or less, and also contain only ASCII alphanumeric characters (i.e. in the range of [a-z], [A-Z], or [0-9]), or the dash (-) character. '.
Could you please update this? It would be useful to add it to the Sample sheet input section as well, please.
I also didn't find it too clear whether users can use the underscore (which, we can), so that may be an improvement to the usage page as well.
Adding it to the error message ouput within the command line would be useful as well.

It's just that dashes were allowed before so users returning after a while could fall into this rookie trap (laughing).

Thank you !

Command used and terminal output

Relevant files

No response

System information

No response

@tremblayemilie tremblayemilie added the bug Something isn't working label Jan 8, 2025
@d4straub
Copy link
Collaborator

Thanks again for opening the issue report, that will be updated for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants