Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash for geocoder not working #405

Open
hanbyul-here opened this issue Jul 7, 2017 · 2 comments
Open

Hash for geocoder not working #405

hanbyul-here opened this issue Jul 7, 2017 · 2 comments

Comments

@hanbyul-here
Copy link
Contributor

hanbyul-here commented Jul 7, 2017

Hash for geocoder looks up the place key of which value should be gid. and callsplace function of geocoder.

This function used to place a marker on the map, but no more (https://github.com/mapzen/leaflet-geocoder/blob/6b20d53f39fdcad99acb4092d8270137f19ea7c4/src/core.js#L303). (It still makes a call, but doesn't do anything with the result)

@hanbyul-here
Copy link
Contributor Author

so Leaflet geocoder officially doesn't support place call results. However the result can be still accessed through results event : https://github.com/mapzen/leaflet-geocoder#interaction-behavior

@hanbyul-here
Copy link
Contributor Author

hanbyul-here commented Aug 8, 2017

  • Working on this branch
  • it becomes funky when used with Leafet Routing Machine, because both of them fight to have priority setting the view. At least mapzen.js should throw warning message that geocoder and routing machine wouldn't work that nicely together
  • Set up the test dedicated to geocoder hash
  • Change lat, lng, zoom hash value according to selected place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant