Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit design of filter badges #1938

Open
joverlee521 opened this issue Jan 22, 2025 · 0 comments
Open

Revisit design of filter badges #1938

joverlee521 opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

Initially brought up by @jameshadfield in #1924 (comment)

Probably beyond this PR, but this makes me think about some improvements to the filter badges - they haven't seen any development since they were first introduced and filtering has become a much bigger part of workflows since then.

It'd be nice to show the title not the key when hovering, and even nicer if we could somehow render this in the badge itself, as a badge simply showing "true" isn't very intuitive. We already do both of these in the sidebar
image

Also brought up by @trvrb in #1924 (comment)

  1. The "filtered to true" is a bit strange and should be clearer.
Screenshot 2025-01-21 at 5 23 58 PM

The box in the side bar is properly clear:

Screenshot 2025-01-21 at 5 27 57 PM

Description

We should revisit the design of the filter badges displayed at the top of the page. We can try displaying the filter title along with the filter value in the badges, but be aware of long titles and values. The badges can already look a bit clunky when there are multiple filters with long field values.

Image

(We already try to avoid long author lists in builds for bad display reasons, but just using this as example.)

@joverlee521 joverlee521 added the enhancement New feature or request label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant