From 92b0560e2433a7d064e125bbdbd4e41ea8bac9ce Mon Sep 17 00:00:00 2001 From: Victor Lin <13424970+victorlin@users.noreply.github.com> Date: Fri, 4 Oct 2024 16:41:29 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A7=20add=20note=20on=20re-focus=20w/?= =?UTF-8?q?=20filter=20change?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/actions/tree.js | 1 + src/components/tree/reactD3Interface/change.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/actions/tree.js b/src/actions/tree.js index a5f7de910..d40b51814 100644 --- a/src/actions/tree.js +++ b/src/actions/tree.js @@ -294,6 +294,7 @@ export const applyFilter = (mode, trait, values) => { } dispatch({type: types.APPLY_FILTER, trait, values: newValues}); dispatch(updateVisibleTipsAndBranchThicknesses()); + // FIXME: re-focus with one of the above dispatches or new dispatch }; }; diff --git a/src/components/tree/reactD3Interface/change.js b/src/components/tree/reactD3Interface/change.js index 40d2642a2..d91cbdba4 100644 --- a/src/components/tree/reactD3Interface/change.js +++ b/src/components/tree/reactD3Interface/change.js @@ -50,6 +50,7 @@ export const changePhyloTreeViaPropsComparison = (mainTree, phylotree, oldProps, } /* change treeFocus behavior */ + // FIXME: updateLayout when filters have changed to re-focus if (oldProps.treeFocus !== newProps.treeFocus) { args.newTreeFocus = newProps.treeFocus; args.updateLayout = true;