-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling watermarking on the Office app breaks previews for public albums on the Memories app #4331
Comments
Are you able to share with us any relevant excerpts from your |
Of course.
Here is the list of browser console messages:
And if I expand one of the error 500s:
|
The logs only show debug level messages, but your browser seems to fail with a 500 error on the memories endpoint: Can you check if you find any specific message for those endpoints in the logs, e.g. with this filter:
|
Here is the output of your grep:
I have narrowed this down further. The previews break only if "Show watermark for read only shares" or "Show watermark for all shares" is selected in the Watermark section in Office admin settings. EDIT: The tickbox options under 'Link shares' appear to have no effect on this issue, whether ticked or unticked they don't affect whether previews are broken or not. The only culprit seems to be the "Show watermark for read only shares" (and the "Show watermark for all shares"). |
Thanks, doesn't hint a log message but it might be influenced by
I haven't checked if the memories app might be silencing that exception, but we probably should harden the code a bit and check what cases we want to block previews (maybe limit to office formats there). |
is it correlated to #4103? |
I have noticed this issue before when sharing individual files, but never thought office is causing this. One thing I would like to add is even when you view the shared file without using memories (i.e. apps/memories/ is removed from the url) the previews are not loaded. Instead the full resolution image is downloaded. So the issue is not with memories I guess. |
Describe the bug
If 'watermarking' is enabled on the Office app's admin settings, it breaks previews in publicly shared albums on the Memories app. In this case, the Memories app shows placeholders in place of thumbnails, and also shows placeholders in place of the full photo if 'load full size' is not selected.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Previews on shared albums showing normally.
Client details:
Server details
Operating system: Ubuntu 20.04
Web server: Nginx
Database: Postgresql
PHP version: 8.3
Nextcloud version: 29.0.3
Version of the richdocuments app: 8.4.9
Version of Collabora Online: 24.04.10.2
Configuration of the richdocuments app:
Logs
Nextcloud log (data/nextcloud.log)
Browser log
Here is a snippet of a failed GET request for the previews when opening a shared album in Memories, with Office watermarking switched on:
The text was updated successfully, but these errors were encountered: