Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Availability Integration: Leverage async callback to implement a loading state #6621

Open
st3iny opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Integration An integration with another app in the ecosystem

Comments

@st3iny
Copy link
Member

st3iny commented Jan 13, 2025

Is your feature request related to a problem? Please describe.

Opening the availability modal from either the NcAvatar or ContactsMenu action might take some time to load. During the loading phase there is no feedback to the user. The modal will simply pop up after some time.

Describe the solution you'd like

We should leverage an async callback to implement a loading state. Render the button in a loading state while the Promise is being resolved until the modal is shown.

Describe alternatives you've considered

None

Additional context

Follow-up to nextcloud/server#49375

Nitpick deluxe: consider handling async callbacks, to allow actions to signal when they are done. E.g. the screencast at #6502 shows that there is a brief moment of no visual feedback before the modal opens. During that time the action button could switch to a loading state. On a technical level the callback would return a promise, and here you would go into loading state as long as the promise hasn't resolved.
nextcloud/server#49375 (comment)

@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Integration An integration with another app in the ecosystem labels Jan 13, 2025
@st3iny st3iny self-assigned this Jan 13, 2025
@st3iny st3iny moved this to 🧭 Planning evaluation in 💌 📅 👥 Groupware team Jan 13, 2025
@st3iny st3iny moved this from 🧭 Planning evaluation to 📄 To do in 💌 📅 👥 Groupware team Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request Feature: Integration An integration with another app in the ecosystem
Projects
Status: 📄 To do
Development

No branches or pull requests

1 participant