Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-modal dialogs #133

Open
gbracha opened this issue Jan 14, 2025 · 0 comments
Open

Non-modal dialogs #133

gbracha opened this issue Jan 14, 2025 · 0 comments

Comments

@gbracha
Copy link
Member

gbracha commented Jan 14, 2025

Hopscotch does have direct support for non-modal dialogs. One has to construct them by hand. For example, when adding a class or document. In other cases, we simply transition to a dedicated presenter for the dialog. We should make this easier.

We support the web browser's window.alert() method directly, which is modal; this violates a key tenet of the Hopscotch design. It would be tempting to add support for window.confirm() in the same way. This is trivial, but leads to perdition.
Instead, we should support patterns like alert, confirm, and other input dialogs in a non-modal way. A call to confirm might add a banner at the top of the presenter with the dialog (much like the help display is managed today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant