Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates must be able to reference other templates (hierarchal templates) #2

Open
kwatsen opened this issue Nov 13, 2024 · 2 comments

Comments

@kwatsen
Copy link

kwatsen commented Nov 13, 2024

Requirements

This requirement is to enable templates to themselves reference other template(s).

Note: whether a template can reference one temaplate or a list of templates is addressed in #1.

Non-Requirements

Implicit in this requirement is a need to define a rule for how overlaps/collisions are handled. Though a common approach/understanding is to allow local-overrides, this requirement does NOT pick what approach may be used, leaving that decision to be made elsewhere.

@kwatsen kwatsen changed the title templates must be able to reference other templates (hierarchal templates) Templates must be able to reference other templates (hierarchal templates) Nov 13, 2024
@jsterne
Copy link

jsterne commented Nov 14, 2024

This feels overly complex to me. Being able to compose a config using multiple templates is good (issue #1), and same with being able to apply at various schema nodes (issue #9) and probably good enough for most use cases of templates.

@robertjwills
Copy link

robertjwills commented Jan 7, 2025

I think this adds complexity for several reasons:

  • Making sure templates don't reference each other in a circular way
  • When combined with issue #1, there are now two ways that the contents of templates can collide
  • Needing to specify and implement validation for when a referenced template doesn't exist. Of course this is already the case, but now we have an extra situation where one template may reference another that doesn't exist.

I agree with Jason that #1 and #9 are good enough for most use cases of templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants