Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASL documentation using deprecated CASL code #11242

Closed
3 of 15 tasks
muametgrooby opened this issue Mar 8, 2023 · 1 comment
Closed
3 of 15 tasks

CASL documentation using deprecated CASL code #11242

muametgrooby opened this issue Mar 8, 2023 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@muametgrooby
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Nestjs documentation uses deprecated functions from CASL, copy-pasting it brings up deprecation errors
https://docs.nestjs.com/security/authorization#advanced-implementing-a-policiesguard

Minimum reproduction code

https://docs.nestjs.com/security/authorization#advanced-implementing-a-policiesguard

Steps to reproduce

Look at the documentation for implementing CASL

Expected behavior

there should be no deprecation warnings when I follow the guide in documentation

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

@casl/ability

NestJS version

NA

Packages versions

{
    "@casl/ability": "^6.3.3"
}

Node.js version

18

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@muametgrooby muametgrooby added the needs triage This issue has not been looked into label Mar 8, 2023
@micalevisk
Copy link
Member

this should be fixed by PR nestjs/docs.nestjs.com#2597

thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

3 participants