Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add garden size estimate evaluation notebook #115

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

crispy-wonton
Copy link
Collaborator

@crispy-wonton crispy-wonton commented Jan 22, 2025

Fixes #114

Description

add garden size estimate evaluation notebook

Instructions for Reviewer

to generate the notebook, ensure jupytext is installed and then run the following line in terminal:
jupytext --to notebook asf_heat_pump_suitability/analysis/garden_size_estimates/20250106_evaluate_garden_size_estimates.py

Please pay special attention to ...
Please could you provide some feedback on this analysis. Namely:

  • Do you think the selection criteria are appropriate and applied in the correct order?
  • Have I accounted for the appropriate corrections to make this a fair analysis (e.g. applying weights, checking weights add to at least 0.9 etc.)
  • Are there any suggestions you have to make the analysis more robust or accurate?
  • Have the weights been applied correctly?
  • Is there anything we should add to the analysis?

Checklist:

  • I have refactored my code out from notebooks/
  • I have checked the code runs
  • I have tested the code
  • I have run pre-commit and addressed any issues not automatically fixed
  • I have merged any new changes from dev
  • I have documented the code
    • Major functions have docstrings
    • Appropriate information has been added to READMEs
  • I have explained this PR above
  • I have requested a code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate garden size estimates
1 participant