Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread id to the Connection class #2902

Closed
pnbabu opened this issue Aug 23, 2023 · 2 comments
Closed

Add thread id to the Connection class #2902

pnbabu opened this issue Aug 23, 2023 · 2 comments
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation

Comments

@pnbabu
Copy link
Contributor

pnbabu commented Aug 23, 2023

Currently, the send() function in the Connection class is the only place where the thread_id of the connection is available. This issue is to propose adding a new variable, thread_id to the Connection class as a private member and a corresponding private function get_thread() that returns the thread id. This makes it easier to query the thread_id from all the functions in the synapse models, along with the models written in NESTML.

The idea is to introduce a new variable unsigned short int thread_id in the Connection class. The connection object has a target identifier target_ is 16 bits + 16 bits of padding + 32 bits of SynIdDelay data structure. The 16 bits of padding could be used for the connection's thread ID.

@JanVogelsang JanVogelsang added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 24, 2023
@github-actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Oct 24, 2023
@jessica-mitchell jessica-mitchell moved this to To do in Models Aug 6, 2024
@jessica-mitchell jessica-mitchell moved this to To do (open issues) in Kernel Aug 6, 2024
@pnbabu
Copy link
Contributor Author

pnbabu commented Jan 13, 2025

As mentioned in #2921, the thread_id can be accessed via kernel().vp_manager.get_thread_id() from the synapse. A new issue is opened for this in NESTML: nest/nestml#1158. Closing this issue for now.

@pnbabu pnbabu closed this as completed Jan 13, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Models Jan 13, 2025
@github-project-automation github-project-automation bot moved this from To do (open issues) to Done in Kernel Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants