Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup cross-project dependencies #1923

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Jan 27, 2025

  • Use attributes to resolve the correct variant of the neoforge project, in tests. Since runtimeElements and universalJar have the same attributes, and adding attributes to universalJar would be a breaking change, I added an internal attribute to runtimeElements instead.
  • Fix testframework being published with a runtime dependency on the universal jar. Now there is no dependency whatsoever.
  • Fix java version attribute of the universalJar being the Java version used to run Gradle rather than the Java version of the toolchain.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 27, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 27, 2025

  • Publish PR to GitHub Packages

Last commit published: 169fb5ab69ac55028efd7a000f1b076597f2ccde.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1923' // https://github.com/neoforged/NeoForge/pull/1923
        url 'https://prmaven.neoforged.net/NeoForge/pr1923'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1923.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1923
cd NeoForge-pr1923
curl -L https://prmaven.neoforged.net/NeoForge/pr1923/net/neoforged/neoforge/21.4.82-beta-pr-1923-cleanup-x-project-deps/mdk-pr1923.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n Technici4n added cleanup Change that isn't an enhancement or a bug fix ci/build Related to continuous integration/build system labels Jan 27, 2025
tests/build.gradle Outdated Show resolved Hide resolved
testframework/build.gradle Outdated Show resolved Hide resolved
@Technici4n Technici4n requested a review from lukebemish January 27, 2025 22:20
@Technici4n Technici4n merged commit b19a079 into neoforged:1.21.x Jan 29, 2025
6 checks passed
@Technici4n Technici4n deleted the cleanup-x-project-deps branch January 29, 2025 20:25
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.78-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 ci/build Related to continuous integration/build system cleanup Change that isn't an enhancement or a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants