Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global block entities not being updated for empty sections #1873

Merged

Conversation

Technici4n
Copy link
Member

1.21.1 backport of #1865.

@neoforged-automation neoforged-automation bot added the 1.21.1 Targeted at Minecraft 1.21.1 label Jan 18, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 18, 2025

  • Publish PR to GitHub Packages

Last commit published: 3c8df8e74f84dad5eca8aff78975a2fbc1317d4c.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1873' // https://github.com/neoforged/NeoForge/pull/1873
        url 'https://prmaven.neoforged.net/NeoForge/pr1873'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1873.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1873
cd NeoForge-pr1873
curl -L https://prmaven.neoforged.net/NeoForge/pr1873/net/neoforged/neoforge/21.1.97-pr-1873-fix-global-be-empty-section-1.21.1/mdk-pr1873.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same patch as original PR, and tested to work.

@sciwhiz12 sciwhiz12 added bug A bug or error backport Backport to an older version from a newer version vanilla bug A bug or error in the base Minecraft game labels Jan 19, 2025
@sciwhiz12 sciwhiz12 merged commit ea6aecf into neoforged:1.21.1 Jan 19, 2025
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 backport Backport to an older version from a newer version bug A bug or error vanilla bug A bug or error in the base Minecraft game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants