We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minecraft Version: 1.21.1
NeoForge Version: 21.1.92
Steps to Reproduce:
/attribute @s neoforge:swim_speed base set 100
Description of issue: Swim speed applies only to vertical movement in lava.
Code analysis: This appears to be because in the LivingEntity patch the fluid is checked to be water before applying bonus sideways velocity:
NeoForge/patches/net/minecraft/world/entity/LivingEntity.java.patch
Lines 521 to 529 in 5e4bfbf
NeoForge/src/main/java/net/neoforged/neoforge/common/extensions/ILivingEntityExtension.java
Lines 32 to 34 in 5e4bfbf
Suggested Solution: In the jumpInFluid method check the fluid type is water before applying bonus momentum.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Minecraft Version: 1.21.1
NeoForge Version: 21.1.92
Steps to Reproduce:
/attribute @s neoforge:swim_speed base set 100
Description of issue:
Swim speed applies only to vertical movement in lava.
Code analysis:
This appears to be because in the LivingEntity patch the fluid is checked to be water before applying bonus sideways velocity:
NeoForge/patches/net/minecraft/world/entity/LivingEntity.java.patch
Lines 521 to 529 in 5e4bfbf
However the jumpInFluid method that is called for vertical movement does not check fluid type before applying bonus momentum:
NeoForge/src/main/java/net/neoforged/neoforge/common/extensions/ILivingEntityExtension.java
Lines 32 to 34 in 5e4bfbf
Suggested Solution:
In the jumpInFluid method check the fluid type is water before applying bonus momentum.
The text was updated successfully, but these errors were encountered: