Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull #1334 Broke ATs and made it impossible to access a vanilla class #1691

Closed
Tslat opened this issue Nov 16, 2024 · 1 comment · Fixed by #1708
Closed

Pull #1334 Broke ATs and made it impossible to access a vanilla class #1691

Tslat opened this issue Nov 16, 2024 · 1 comment · Fixed by #1708
Labels
triage Needs triaging and confirmation

Comments

@Tslat
Copy link

Tslat commented Nov 16, 2024

https://github.com/neoforged/NeoForge/pull/1334/files#diff-ea2381c7e0cc2da3a49d2e32731191728a6c03a5182c6c9ba51153dd90ca032eR44

Patched the vanilla record class AttributeTemplate, but didn't make it or its constructor public

So the class is now inaccessible and breaking my mods

Pls fix.
@Tslat Tslat added the triage Needs triaging and confirmation label Nov 16, 2024
@Tslat Tslat mentioned this issue Nov 16, 2024
Closed
@TelepathicGrunt TelepathicGrunt mentioned this issue Nov 26, 2024
Merged
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.3.51-beta, as part of #1708.

@neoforged-automation neoforged-automation bot mentioned this issue Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Needs triaging and confirmation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make AttributeTemplate record public TelepathicGrunt/NeoForge
1 participant
@Tslat