From 788ddb1821b8a1ca84640856a9124691ffceaeda Mon Sep 17 00:00:00 2001 From: Sara Freimer Date: Tue, 28 Jan 2025 15:41:48 -0600 Subject: [PATCH] Cleaner way to implement sendSuccess --- .../neoforged/neoforge/client/ClientCommandSourceStack.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/neoforged/neoforge/client/ClientCommandSourceStack.java b/src/main/java/net/neoforged/neoforge/client/ClientCommandSourceStack.java index f02c8094b6..a3940ca3e0 100644 --- a/src/main/java/net/neoforged/neoforge/client/ClientCommandSourceStack.java +++ b/src/main/java/net/neoforged/neoforge/client/ClientCommandSourceStack.java @@ -56,9 +56,8 @@ private ClientPacketListener connection() { */ @Override public void sendSuccess(Supplier message, boolean sendToAdmins) { - if (this.source.acceptsSuccess() && !isSilent()) { - this.source.sendSystemMessage(message.get()); - } + //Don't send the message to admins, as that requires querying the server for the list of admins, and would cause a NPE + super.sendSuccess(message, false); } /**