'plain' mails ?

[noebi]

Hi,
call me old-fashioned, but I prefer simple plain text messages.
It seems, however, that slurm-mail has 'html' hardcoded as the mail type.
A simple patch like the one below makes this a config option:

--- src/slurmmail/cli.py.orig   2024-01-10 13:11:46.000000000 +0100
+++ src/slurmmail/cli.py        2024-01-11 09:04:04.057233202 +0100
@@ -577,7 +577,7 @@
         msg["From"] = options.email_from_address
         msg["Date"] = email.utils.formatdate(localtime=True)
         msg["Message-ID"] = email.utils.make_msgid()
-        msg.attach(MIMEText(body, "html"))
+        msg.attach(MIMEText(body, options.email_type))
         logging.info(
             "Sending e-mail to: %s using %s for job %s (%s) via SMTP server %s:%s",
             job.user,
@@ -666,6 +666,10 @@
         options.email_from_name = config.get(section, "emailFromName")
         options.email_subject = config.get(section, "emailSubject")
         options.validate_email = config.getboolean(section, "validateEmail")
+        if not config.has_option(section, "emailType"):
+            options.email_type = "html"
+        else:
+            options.email_type = config.get(section, "emailType");
         options.sacct_exe = pathlib.Path(config.get(section, "sacctExe"))
         options.scontrol_exe = pathlib.Path(config.get(section, "scontrolExe"))
         options.datetime_format = config.get(section, "datetimeFormat")

Needs suitable templates of course. Works fine at our sites.
Won't hurt to include it, would it ?

Regards,
N.

[neilmunday]

Hi @noebi,

Thanks for this suggestion. I've created issue #108 to track this request.

Regards,

Neil.

[neilmunday]

Version 4.10 released which includes support for HTML and plain text e-mails.