Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flawed Python versioning check #13

Open
mathscantor opened this issue Sep 18, 2024 · 0 comments
Open

Flawed Python versioning check #13

mathscantor opened this issue Sep 18, 2024 · 0 comments

Comments

@mathscantor
Copy link

mathscantor commented Sep 18, 2024

Hi, I would like to point out an issue regarding the versioning check at start of deploy.py.

I'm currently on python 3.12.4 and the tuple comparison is not comparing integers but strings.
You can reproduce the bug with the python console commands below:

Python 3.12.4 | packaged by Anaconda, Inc. | (main, Jun 18 2024, 15:12:24) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> ('3', '9', '4') < ('3', '2', '0')
False
>>> ('3', '10', '4') < ('3', '2', '0')
True
>>> '10' < '2'
True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant