Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating storage path fails due to bad mkdirp option. #6

Open
bnielsen1965 opened this issue Feb 14, 2020 · 1 comment
Open

Creating storage path fails due to bad mkdirp option. #6

bnielsen1965 opened this issue Feb 14, 2020 · 1 comment

Comments

@bnielsen1965
Copy link

The mkdirp node module has breaking changes from version 0.5 to 1.0 and the package.json for nedb-core is requesting the "latest" version of mkdirp. This breaks nedb-core which relies on mkdirp version 0.5.

There are two options to fix the issue...

  1. Change the package.json dependency to mkdirp version 0.5.

  2. Update the nedb-core persistence library to use the new mkdirp async methods.

I can put together a pull request but I'm curious which option would be more acceptable. Option 1 would be easy and low risk. Option 2 would be more forward looking but would require code changes that would come with risks.

Thought?

@rahulsushilsharma
Copy link

Thanks man for the heads up really saved lot of debugging time, used the old mkdirp version 0.5 for now works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants