You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mkdirp node module has breaking changes from version 0.5 to 1.0 and the package.json for nedb-core is requesting the "latest" version of mkdirp. This breaks nedb-core which relies on mkdirp version 0.5.
There are two options to fix the issue...
Change the package.json dependency to mkdirp version 0.5.
Update the nedb-core persistence library to use the new mkdirp async methods.
I can put together a pull request but I'm curious which option would be more acceptable. Option 1 would be easy and low risk. Option 2 would be more forward looking but would require code changes that would come with risks.
Thought?
The text was updated successfully, but these errors were encountered:
The mkdirp node module has breaking changes from version 0.5 to 1.0 and the package.json for nedb-core is requesting the "latest" version of mkdirp. This breaks nedb-core which relies on mkdirp version 0.5.
There are two options to fix the issue...
Change the package.json dependency to mkdirp version 0.5.
Update the nedb-core persistence library to use the new mkdirp async methods.
I can put together a pull request but I'm curious which option would be more acceptable. Option 1 would be easy and low risk. Option 2 would be more forward looking but would require code changes that would come with risks.
Thought?
The text was updated successfully, but these errors were encountered: