Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match?-declaration in u-t.matcher-combinators #37

Open
thumbnail opened this issue Dec 8, 2020 · 0 comments
Open

Add match?-declaration in u-t.matcher-combinators #37

thumbnail opened this issue Dec 8, 2020 · 0 comments

Comments

@thumbnail
Copy link
Member

Problem statement

match? is a multi-method dispatch symbol, not a function. So it misses highlighting and a proper refer.

This has a couple of caveats:

  • lack of traceability. The assert-expr is registered when nedap.utils.test.matcher-combinators is loaded, which might be in a different ns
  • formatters might remove [nedap.utils.test.matcher-combinators] as a dependency, if it is only loaded for registering the match?-matcher.

Proposal

add a declaration for the multimethod. Similar to matcher-combinators:
https://github.com/nubank/matcher-combinators/blob/b3da18923f0aa6a5ef924e9303f690a3efa1d978/src/cljc/matcher_combinators/test.cljc#L10-L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant