Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore trivy finding for public egress #2919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ignore trivy finding for public egress #2919

wants to merge 1 commit into from

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Jan 21, 2025

Reference Issues or PRs

closes #2882

What does this implement/fix?

This alert is because the security group has an egress rule that allows egress to 0.0.0.0/0. Reference for the finding is at https://avd.aquasec.com/misconfig/aws/ec2/avd-aws-0104/

However, the nature of the type of work done in Nebari means that we need this rule, and since it is an egress rule we choose to accept this risk.

This PR causes trivy to ignore this finding for this resource. It is as narrowly scoped as possible so that if this rule finds other instances we can address them if needed.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Merge and check the security table.

Any other comments?

@dcmcand dcmcand added needs: review 👀 This PR is complete and ready for reviewing provider: AWS area: CI/CD 👷🏽‍♀️ area: security 🔐 area: networking All items related to networking labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD 👷🏽‍♀️ area: networking All items related to networking area: security 🔐 needs: review 👀 This PR is complete and ready for reviewing provider: AWS
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - An egress security group rule allows traffic to /0.
1 participant