Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP core fill: currentColor is blacking out some custom icons #63

Open
JiveDig opened this issue Dec 26, 2024 · 2 comments
Open

WP core fill: currentColor is blacking out some custom icons #63

JiveDig opened this issue Dec 26, 2024 · 2 comments

Comments

@JiveDig
Copy link

JiveDig commented Dec 26, 2024

The code from core is:

.components-button svg {
  fill: currentColor;
  outline: none;
}

It's forcing my Heroicons to be all black in the picker:
CleanShot 2024-12-26 at 16 21 39@2x

The icons themselves have fill="none".
CleanShot 2024-12-26 at 16 22 33@2x

@JiveDig JiveDig changed the title WP core fill: currentColor is blacking out my icons WP core fill: currentColor is blacking out some custom icons Dec 26, 2024
@JiveDig
Copy link
Author

JiveDig commented Dec 26, 2024

This is also happening on the front end... hmmm, maybe an issue specific to Heroicons, because FontAwesome isn't doing it.

CleanShot 2024-12-26 at 17 06 10@2x

@JiveDig
Copy link
Author

JiveDig commented Dec 26, 2024

Okay, so this happens when you set the icon color and the "Apply icon color to fill" setting is automatically enabled. Disabling it fixes the issue. I guess it makes sense to leave it enabled for the default and most icon sets.

Nick, if this all makes sense and you think it should remain is-is, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant