Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model is not a DAG #332

Closed
13 tasks done
adamjtaylor opened this issue Dec 12, 2023 · 1 comment · Fixed by #344
Closed
13 tasks done

Model is not a DAG #332

adamjtaylor opened this issue Dec 12, 2023 · 1 comment · Fixed by #344
Assignees

Comments

@adamjtaylor
Copy link
Contributor

adamjtaylor commented Dec 12, 2023

In testing the schematic refactor in #322 we get the following warnings re loops in the data model. These will become errors in future versions of schematic, so we should look to implement changes to the data model to remove these loops

  • we found a loop between: RPPALevel2 and HTANRPPAAntibodyTable
  • we found a loop between: MelanomaTier3 and Patient
  • we found a loop between: SarcomaTier3 and Patient
  • we found a loop between: PancreaticCancerTier3 and Patient
  • we found a loop between: Patient and BreastCancerTier3
  • we found a loop between: Patient and SRRSClinicalDataTier2
  • we found a loop between: Patient and NeuroblastomaandGliomaTier3
  • we found a loop between: Patient and LungCancerTier3
  • we found a loop between: Patient and ColorectalCancerTier3
  • we found a loop between: Patient and ClinicalDataTier2
  • we found a loop between: Patient and AcuteLymphoblasticLeukemiaTier3
  • we found a loop between: Patient and ProstateCancerTier3
  • we found a loop between: Patient and OvarianCancerTier3
@adamjtaylor
Copy link
Contributor Author

adamjtaylor commented Jan 5, 2024

@mialy-defelice advises removing Depends On Component from most of these. This aligns with how we have other components set up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant