Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TST as valid value for “Single Nucleus Buffer" #307

Closed
9 tasks
clarisse-lau opened this issue Oct 3, 2023 · 6 comments · Fixed by #313
Closed
9 tasks

Add TST as valid value for “Single Nucleus Buffer" #307

clarisse-lau opened this issue Oct 3, 2023 · 6 comments · Fixed by #313
Assignees
Labels
effort-mid This one needs your brain

Comments

@clarisse-lau
Copy link
Contributor

Information

Proposed change:

Add TST as option for required attribute Single Nucleus Buffer
Current valid values are : NIB, 10x, Omni


Dicussion link:

Email from Allison Frangieh (DFCI) Oct 3, 2023:

We are working on submitting the ScATAC-seqLevel1 spreadsheet on the DCA for our snRNAseq TNP data. We’re having trouble with one column:

“Single Nucleus Buffer”- this is a required field and “unknown” or “not applicable” (in any variation) is not accepted. The valid values are 10x, NIB, or Omni, but none are applicable to the protocol we used (i.e. TST buffer from Slyper et al. paper). I think we are unable to submit until this error is resolved.


How important is this feature?

  • 🌋 Important - it's a blocker and can't do work without it

When will use cases depending on this become relevant?

  • Short-term - 2-4 weeks

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@aclayton555 aclayton555 added the effort-mid This one needs your brain label Oct 10, 2023
@aclayton555
Copy link
Contributor

@elv-sb can tackle this during this sprint! Thanks!

@clarisse-lau
Copy link
Contributor Author

Hi @aclayton555 @elv-sb @adamjtaylor !

Our collaborator is asking for an estimated timeline for when this will be available in DCA. Will this update be included in the next data model release (end of the month, I presume)?

@adamjtaylor
Copy link
Contributor

@clarisse-lau asked that we escalate during our CRDC call so I have implemented and will push through

@clarisse-lau
Copy link
Contributor Author

Thanks @adamjtaylor !

@adamjtaylor
Copy link
Contributor

@clarisse-lau this should now be live in production. 🚀

@clarisse-lau
Copy link
Contributor Author

Have notified the user. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-mid This one needs your brain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants