Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent date literal on line 78 will cause script maintenance issues in the future #36

Open
DarrenWHenderson opened this issue May 4, 2021 · 0 comments

Comments

@DarrenWHenderson
Copy link
Collaborator

FROM OBSERVATION_FACT OBS WHERE CONVERT(DATE,OBS.START_DATE) BETWEEN CAST('2020/01/01' AS DATE) AND CAST('12-31-2020' AS DATE)

The date literal '2020/01/01' on line 78 is the only time the floor for the one-year census period is written in yyyy/mm/dd format in the entire script. It will make find-replace in future maintenance of the script fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant