Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify import logic across all layouts #729

Open
naher94 opened this issue May 27, 2024 · 0 comments
Open

Simplify import logic across all layouts #729

naher94 opened this issue May 27, 2024 · 0 comments

Comments

@naher94
Copy link
Owner

naher94 commented May 27, 2024

I have to include several files across several layouts which is causing misses. Would be good to have a way to reduce number of places I need to include all the files such as {% include easter-egg-snackbar.html %}, {% include tag-manager.html %} and {% include header.html %}

Also note that the easter-egg-banner does not current fly over the top of hero images because of where it sits in the DOM

default.html, default-hero.html and blank.html are the 3 base layouts as if today that need consolidated. post-hero.html also contains some include logic

@naher94 naher94 mentioned this issue May 27, 2024
8 tasks
naher94 added a commit that referenced this issue May 27, 2024
Relates to #726
TODO Relates to #729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant