Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] join supports on condition #116

Open
zdu-strong opened this issue Jan 27, 2024 · 1 comment
Open

[Feature] join supports on condition #116

zdu-strong opened this issue Jan 27, 2024 · 1 comment

Comments

@zdu-strong
Copy link

zdu-strong commented Jan 27, 2024

I hope join supports custom on conditions, because it can get faster speed than where conditions.

 public <U> JPAJinqStream<Pair<T, U>> join(
       JinqStream.JoinWithSource<T, U> join,
       JinqStream.WhereForOn<T, U> on);

image

@my2iu
Copy link
Owner

my2iu commented Jan 29, 2024

After looking into this some more, it does seem like JPA 2.1 does support JOIN...ON... queries, so it is feasible to support this. It's possible that if you define an entity relationship, then the JPA provider might also be able to make use of this optimization automatically without needing to explicitly use JOIN...ON... in a query.

I don't really have the time to work on major features for Jinq though, so unless the performance issue is so bad that it's absolutely required, then I probably won't be able to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants