'Crystal snapshots' changes not propagated from UI

[elmjag]

There is a Crystal snapshots drop-down in the queue settings:

Changing this value does not seem to have any effect. Regardless of what value you select in that drop-down, the collection hardware object is always invoked with the original value.

The take_snapshots key in the "data collect parameters" never changes, it always remain at the original value.

[marcus-oscarsson]

Crystal snapshots does not change take_snapshots it changes number_of_snapshots on the collect hardware object.

[marcus-oscarsson]

This behavior was changed fairly recently and we might need to discuss if number of snapshots is a data collection parameter that is per data collection. In the past take_snapshots was used a bit ambiguously as a boolean, or sometimes as an int with the number of snapshots. The number of snapshots was passed via a somewhat unconventional patch that was replaced by simply setting collect.number_of_snapshots.

[elmjag]

Crystal snapshots does not change take_snapshots it changes number_of_snapshots on the collect hardware object.

Aha! The fact that take_snapshots is set to numerical values, like 0, 2, 4.. etc confused me. The collect.number_of_snapshots works correctly.

I agree, it would be nice to modify this to make it less confusing.