Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle mvnd 1.x and mvnd 2.x? #12

Closed
cstamas opened this issue Jun 17, 2024 · 8 comments
Closed

How to handle mvnd 1.x and mvnd 2.x? #12

cstamas opened this issue Jun 17, 2024 · 8 comments

Comments

@cstamas
Copy link

cstamas commented Jun 17, 2024

Currently we have one formula mvnd. And mvnd 1.0.0 is out, but soon will come mvnd 2.0.0 as well.

How we want to handle this?

@ppalaga @gnodet

@gnodet
Copy link
Contributor

gnodet commented Jun 17, 2024

Same as Maven ?

@cstamas
Copy link
Author

cstamas commented Jun 17, 2024

Ok, here in maven Formula I see 3.9.8 only:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/m/maven.rb

So it means once mvnd 2.0.0 out, it will replace mvnd 1.0.x (whatever version will be then current)?

@amterp
Copy link

amterp commented Jun 27, 2024

Related to this discussion:

With this change yesterday, brew install mvnd or brew upgrade mvnd will now install 2.0.0-beta, which also uses mvn 4.0.0-beta.

This seems undesirable? A few of us were surprised today when we saw that updating mvnd moved us off a stable release onto not one, but two betas. This caused some build issues for us and we needed to downgrade explicitly with mvnd@1.

@gnodet
Copy link
Contributor

gnodet commented Jun 27, 2024

You can now install mvnd@1 to get the 1.x line.
Homebrew is mostly focusing on installing the latest version. If you want to switch between versions, maybe using sdkman makes more sense.

@cstamas
Copy link
Author

cstamas commented Jun 27, 2024

Updated README:
apache/maven-mvnd@df10018

@paulochang
Copy link

paulochang commented Jun 28, 2024

Hi @gnodet ,
I disagree, according to the documentation, homebrew should install the latest stable version.
Beta versions should be tagged accordingly (https://docs.brew.sh/Acceptable-Casks#beta-unstable-development-nightly-or-legacy). Until a stable release of mvnd 2 is done, IMHO we should keep the version 1 as the main line.

This is also how it's handled in macports and sdkman

My projects stopped running today because of some sort of incompatibility with mvnd 2 and I expect this to be the case for the majority of the users.

@JackPGreen
Copy link

Until a stable release of mvnd 2 is done, IMHO we should keep the version 1 as the main line.
{...}
My projects stopped running today because of some sort of incompatibility with mvnd 2 and I expect this to be the case for the majority of the users.

I agree with this having been caught out in the same way.

More specifically, if you brew install maven you get Apache Maven 3.9.8.
If you brew install mvnd you get Apache Maven Daemon (mvnd) 2.0.0-beta-1 {...} Apache Maven 4.0.0-beta-3

I would expect to be getting the same "latest" version of Maven, just with the daemon wrapper.

I had problems building a project with mvnd and initially thought it was a mvnd incompatibility until I realised the real problem was a new Maven version.

There are issues like this that mean IMO Maven v4 isn't ready to be a default choice yet.

@gnodet gnodet closed this as completed Dec 6, 2024
@gnodet
Copy link
Contributor

gnodet commented Dec 6, 2024

We do have 2 formulas since some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants