-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating the player support table #7
Comments
I think I would add additional information to each player's yaml that says whether the player reports song information or not for a given platform (this allows differentation between "..." and "✖️") and if it:
I don't think the file should contain what metadata the player exactly reports and what it is not being reported as that is (1) a lot of work to maintain and (2) can change and get outdated pretty quickly. Here's an idea for a new root key id: foobar2000
support:
win_winrt:
- setting:
- Go to "Advanced" preferences
- Under "Display" enable "Integrate with Windows Universal Volume Control"
- plugin:
url: https://github.com/ungive/foo_mediacontrol
lin_mpris:
- program:
url: https://github.com/ther0n/beefweb_mpris id: mpv
support:
win_winrt:
- setting:
- Add "media-controls=yes" to "mpv.conf"
- setting:
- Run with the command line argument "--media-controls=yes" Logic: If the platform key (e.g. I envision the desktop app to contain these instructions at some point and to have another key in the player's yaml files for executable names on each operating system, so that Music Presence can detect when a player is running (by monitoring processes) without it needing to play media and then be able to show instructions for how to get these players working with Music Presence when there's instructions for it under the "support" key. See #8 |
Sounds good, I'll see if I have time to work on this as I think it should be pretty doable. |
The player support table from the following link could be generated automatically:
https://github.com/ungive/discord-music-presence/blob/master/documentation/supported-media-players.md
Relevant discussion quoted from this issue: ungive/discord-music-presence#151
@smiba:
The text was updated successfully, but these errors were encountered: