Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on adding courtesy accidentals #25975

Open
4 tasks done
iainhallam opened this issue Jan 3, 2025 · 3 comments
Open
4 tasks done

Crash on adding courtesy accidentals #25975

iainhallam opened this issue Jan 3, 2025 · 3 comments
Assignees
Labels
awaiting reply from user crash Issues involving a crash of MuseScore needs info More information is required before action can be taken plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression MS4 Regression on a prior release

Comments

@iainhallam
Copy link

Issue type

Crash or freeze

Description with steps to reproduce

  1. Enable the Courtesy Accidentals plugin
  2. Open the attached score
  3. Run Configure Courtesy Accidentals, try to select brackets
  4. Apply... crash!

Supporting files, videos and screenshots

MSS 4.4.4 courtesy accidentals crash.zip

What is the latest version of MuseScore Studio where this issue is present?

4.4.4-243461245, revision: github-musescore-musescore-2232670

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Windows 11 Version 2009 or later, Arch.: x86_64

Additional context

I've reinstalled MSS, deleted the plugins from my user Documents folder, and tried on another machine and in every case, while I can use the Add command to get bare accidentals, using the Configure window always causes a crash.

I've tried to reproduce this with a blank new score for a minimal test case, but it seems to work fine with just two notes in the score!

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression MS4 Regression on a prior release labels Jan 3, 2025
@zacjansheski zacjansheski added plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) needs info More information is required before action can be taken labels Jan 7, 2025
@zacjansheski
Copy link
Contributor

When you say "try to select brackets" what do you mean?

This is the configure window I see
Screenshot 2025-01-07 at 1 28 03 PM

Attempting to enable parenthesis does nothing, but I haven't reproduced a crash. Could you please share a screen capture and diagnostic files?

@daruet
Copy link

daruet commented Jan 8, 2025

Also working on a score with the courtesy accidentals plugin on 4.4.4 resulting in crashes.
Score has many parts. More parts than not have multiple voices.

From the configuration window (notes up to the next 2 measures selected, accidentals in parenthesis is checked), clicking "Add accidentals" crashes when done from the complete score.
However if I do this from parts, there is a chance. So far, every part with 2 or less voices seems to work.
The parts with 4 voices are 50-50 if it crashes (the parts that crash, crash every time)

-I opened the file from @iainhallam.
It crashed directly when I pressed "Add accidentals" from the score. (notes up to the next 2 measures selected, accidentals in parenthesis is checked)
When done from the individual parts some worked, some crashed.

@daruet
Copy link

daruet commented Jan 8, 2025

I think I managed to find a work around. The issue is related to how much can be selected at once.

As my score has many parts. I've minimized and attached with only two parts. Flute works, Bassoon 1 crashes.

courtesy accidentals.zip

My option selections
image

For the attached file I can "Add accidentals" on the score. (crashes on actual score with 55 parts)
It also works from part "Flute"
Part "Bassoon 1" crashes if I do not select a range.
Beginning though rehearsal mark 5 - works
Beginning though rehearsal mark 6 - crashes
Rehearsal mark 2 through end - crashes
Rehearsal mark 3 through end - works

Also I looked at the part from @iainhallam.
Using same options as above it crashed for me on the full score.
Working through in overlapping sections it was possible to get through the entire score.
Also some notes from this score with selection ranges (score)
Beginning to and including page 4 - works
Beginning to and including page 5

  • "Add accidentals" doesn't work, but doesn't crash
    *Does something in the background because going back to 4 pages won't work unless you "remove" first
  • "Add" (instead of going to "configure") works, but no parentheses.
    Beginning to and including all except last bar.
  • appears to be same as to and including page 5.
    Selecting all crashes.

Extended score 20 bars (copied Chorus 3 the end).
Selecting original length

  • appears to be same as to and including page 5.
    Selecting original length +10 bars, crashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reply from user crash Issues involving a crash of MuseScore needs info More information is required before action can be taken plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression MS4 Regression on a prior release
Projects
None yet
Development

No branches or pull requests

6 participants