Bogus and useless corruption message

[Jojo-Schmitz]

Issue type

UI bug (incorrect info or interface appearance)

Bug description

No response

Steps to reproduce

Open the score from https://musescore.org/en/node/358354
(or the one attached here Alimento Espiritual.zip)

Error message:

No filename, no error detail.
From the log.

2023-12-27T16:53:02.455 | ERROR | main_thread | Read410::readScore410 | MSCX Fehler in Zeile 0: Ungültige Taktlänge: 1728/768
2023-12-27T16:53:02.456 | ERROR | main_thread | NotationProject::load | failed load, err: [2010] Die Datei „“ ist kritisch beschädigt und kann nicht bearbeitet werden.

Proper details, except for the wrong line number and, again, the missing filename.

Mu3 (rightfully!) reports (on the mscx, resp. Mu3.7 on the mscz):

Filename, line number and the error itself

How the score got into that corrupt state is a different issue... the score stems from Mu 4.1.1

Screenshots/Screen recordings

No response

MuseScore Version

4.2.0

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

We should at the very least give the same detailed error messages as Mu3 did

As a bonus: don't stop at the 1st error, but report them all...

Even better: automagically fix them, by reducing. In this case from 1728/768 to 9/4

[bkunda]

@cbjeukendrup could you please investigate this?
I recall the reason for this dialog variant was that MS4 couldn't actually open the file at all (as opp. to the "open at your own risk" variant).

[Jojo-Schmitz]

Whether Mu4 can open the file or not is not really relevant here, this issue is about the error message being wrong, incomplete and useless

[Jojo-Schmitz]

In https://musescore.org/es/node/358525 you'd find another score corrupted in this way

[Jojo-Schmitz]

Another occurrence in https://musescore.org/en/node/358820

Here with a measure len of 12/128, easily reduced to 3/32

[Jojo-Schmitz]

And another, https://musescore.org/en/node/360049

We'd still need another issue for those bogus measure durations, but I have no idea how to reproduce this.

Although reducing them seems a good step.

[Jojo-Schmitz]

Came up in https://musescore.org/en/node/364069 again

Here a measure len of 1680/1920, which could (and should) get reduced to 7/8 automagically

[Jojo-Schmitz]

Came up again in https://musescore.org/en/node/372371

In this case reducing the bogus len of 200/320 to 10/16 fixed the issue, this could (and should) even be done automagically

@bkunda what info do you need?

So far all the score that reported this error could get fixed by normalizing these bogus measure lengths.

[cbjeukendrup]

I seem to recall this is actually more a "needs review" than a "needs info", to investigate where does it go wrong, how big the impact is, etc.
If anyone happens to have time to perform such investigations, that is of course appreciated.

[Jojo-Schmitz]

Came up again in https://musescore.org/en/node/373531

In this case an invalid and non-reducable measure lenght of -4/4 (well, reducable to -1/1, but that'd still be invalid)
Here dropping the - allows the score to get opened, but reported as corrupt in the affected measure, still better than refusing to open it alltogether and with this meaningless and unhelpull error message

[Jojo-Schmitz]

And another one https://musescore.org/en/node/373769, again easily reducable (120/160 -> 3/4)

[cbjeukendrup]

@Jojo-Schmitz Could you check if #26053 does the job?

[Jojo-Schmitz]

Sure, but not today anymore...

[Jojo-Schmitz]

(it is tomorrow meanwhile ;-))

Here's a set of test files (collected from the cases mention in this issue)
bogus-measure-lenghts.zip

[Jojo-Schmitz]

Of these most open, some with reporting (other) corruptions, some without any issues, some aske to gate saved when closing so something seems to have changed in them

One does not open:

When hittiting "Open anyway", MuseScore crashes. Probably entirely unrelated to the uissue at hand.

This doesn't open either:

So a good error message and no crash

So as far as I'm concerned this PR is ready to get merged ;-)