-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex layout in demos #295
Comments
Yes please! It would be very helpful if you could do that.
… On Nov 8, 2018, at 11:02 PM, David Konsumer ***@***.***> wrote:
I'd be happy to make a PR for flex-layout examples instead of table-layout for all the examples, if there is interest.
I think it would simplify layout, and also be more semantically correct (these things aren't tables.)
Here is an example for AppBar, in react, with branding & a menu, mostly pulled from the example layout:
.mui-appbar {
display: flex;
align-items: center;
}
.mui-appbar > * {
flex: 1;
margin: 0;
padding: 0 10px;
}
.mui-appbar a {
color: inherit;
}
import Appbar from 'muicss/lib/react/appbar'
export default () => (
<Appbar>
<h1 className='mui--text-title'>Sitename</h1>
<ul className='mui-list--inline mui--text-body2 mui--text-right'>
<li><a href='#'>About</a></li>
<li><a href='#'>Pricing</a></li>
<li><a href='#'>Login</a></li>
</ul>
</Appbar>
)
It might even make sense to make some little flex util-classes, but it's simple enough to do it one-off like this, in my opinion.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I can't seem to find the source for the doc-site. Where should I make the changes? For reference, here is the pages that should be converted to non-table layout, in my opinion:
I totally agree about table-layout for HTML Emails. It's a good idea and well-supported with email-client's limited CSS support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd be happy to make a PR for flex-layout examples instead of table-layout for all the examples, if there is interest.
I think it would simplify layout, and also be more semantically correct (these things aren't tables.)
Here is an example for AppBar, in react, with branding & a menu, mostly pulled from the example layout:
It might even make sense to make some little flex util-classes, but it's simple enough to do it one-off like this, in my opinion.
The text was updated successfully, but these errors were encountered: