Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][stepper][docs] react-swipeable-views in Stepper demo is no longer maintained #40998

Closed
jweird opened this issue Feb 7, 2024 · 2 comments
Closed

[material-ui][stepper][docs] react-swipeable-views in Stepper demo is no longer maintained #40998

jweird opened this issue Feb 7, 2024 · 2 comments
Assignees
@soler1212
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation ready to take Help wanted. Guidance available. There is a high chance the change will be accepted support: docs-feedback Feedback from documentation page

Comments

@jweird
Copy link

jweird commented Feb 7, 2024 •
edited by github-actions bot
Loading

Related page

https://mui.com/material-ui/react-stepper/#text-with-carousel-effect

Kind of issue

Other

Issue description

Hello in the example for MobileStepper component in Stepper it uses react-swipeable-views which appears to be deprecated/no longer maintained.

Context

There should be a warning about react-swipable-views no longer supported for React 18 or demo should be changed completely to no longer use it.

Search keywords: react-swipeables-views, react18, stepper

Search keywords:
@jweird jweird added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Feb 7, 2024
@flaviendelangle flaviendelangle transferred this issue from mui/mui-x Feb 8, 2024
@zannager zannager added the component: stepper This is the name of the generic UI component, not the React module! label Feb 8, 2024
@samuelsycamore
Copy link
Contributor

Thanks for reporting this @jweird ! As a quick and easy fix, I'd say we should go ahead and just remove this demo since react-swipeable-views is no longer maintained.

@samuelsycamore samuelsycamore changed the title React Swipeable Views is deprecated for React 18 [docs] [material-ui][stepper][docs] react-swipeable-views in Stepper demo is no longer maintained Mar 4, 2024
@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2024
@soler1212
Copy link
Contributor

soler1212 commented Apr 15, 2024 •
edited
Loading

Also the usage of react-swipeable-view requires attention in the following components:

I am working on it

@soler1212 soler1212 mentioned this issue Apr 15, 2024
Merged
1 task
@zanivan zanivan closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soler1212 soler1212

Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation ready to take Help wanted. Guidance available. There is a high chance the change will be accepted support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mnajdova @soler1212 @jweird @zanivan @samuelsycamore @zannager