Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Split Schemes to another set #430

Closed
gwax opened this issue Jul 25, 2017 · 7 comments
Closed

Split Schemes to another set #430

gwax opened this issue Jul 25, 2017 · 7 comments
Labels
Milestone

Comments

@gwax
Copy link
Contributor

gwax commented Jul 25, 2017

In archenemy sets, we currently conflate cards and schemes

Schemes should be split out to a separate "set" in much the same way that Timespiral splits Timeshifted cards to another set or masterpieces are split to another set.

Relates to #49 and #429

@gwax gwax added this to the 4.0 milestone Jul 25, 2017
@fenhl fenhl added the discuss label Jul 25, 2017
@fenhl
Copy link
Contributor

fenhl commented Jul 25, 2017

I disagree. They are part of the same physical product, and have the same set code and set symbol. The different form factor is not a valid reason to split them, in the same way that we don't have separate sets for the oversized commanders from the precons.

@gwax
Copy link
Contributor Author

gwax commented Jul 25, 2017

They have a different numbering scheme. Keeping them in the same set means there are multiple cards with the number "1".

I think the oversized commanders should be separate.

Combining them downstream is a LOT easier than splitting them apart downstream.

@ZeldaZach
Copy link
Member

Going on the basis of how we've done this before (With timespiral stuff) I think it would be a fine split and agree with @gwax in this situation.

@fenhl
Copy link
Contributor

fenhl commented Jul 26, 2017

How do we handle pFNM, which also reuses the card numbers 1–12 each year?

@gwax
Copy link
Contributor Author

gwax commented Jul 26, 2017

That's a very good question @fenhl

Can you help me understand why, for your use case, it is important to keep the schemes in the same "set" as the other, non-scheme, cards?

@fenhl
Copy link
Contributor

fenhl commented Jul 26, 2017

One of my use-cases is mtg.wtf, whose advanced search syntax I use heavily. I don't want to have to memorize a made-up set code if at all avoidable.

As far as I can tell, everything points toward the current situation being correct. pFNM and Tamiyo's Journal (#410) are precedent for multiple cards with the same collector number in the same set.

@gwax
Copy link
Contributor Author

gwax commented Jul 27, 2017

@fenhl has brought me around

@gwax gwax closed this as completed Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants