Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Unraid Template #58

Open
JPDVM2014 opened this issue Dec 26, 2024 · 10 comments
Open

Created Unraid Template #58

JPDVM2014 opened this issue Dec 26, 2024 · 10 comments

Comments

@JPDVM2014
Copy link

Thanks for making this! I just wanted to put a quick issue to let you know I created a template for the Unraid Community Applications store. It should be there once the app store updates.

If there are any issues, hopefully people stop by my support thread on the Unraid forums first, but if they end up here, feel free to send them my way if it looks like an Unraid issue. Thanks!

@mrusse
Copy link
Owner

mrusse commented Dec 28, 2024

Looks great thank you so much! The instructions you have made looks good as well and I am sure it will be helpful for unraid users. Just curious about the chown command you have provided to update the ownership of the slskd folder. Would the SLSKD_UMASK env var in Slskd fix this as well? If so it could be better than running a chown command. You probably have a better idea than me though. Thanks again!!

@JPDVM2014
Copy link
Author

I'll take a look at that! Unfortunately the slskd template that is in the app store runs as root if people don't know to change it. I figured the chown was the easiest way to get everyone on the same page, but I also didn't know about the SLSKD_UMASK var, so I'll have to check.

@tubededentifrice
Copy link
Contributor

Hey there, I think clearer instructions should be set for Unraid users (or actually any one following Trash Guides to setup *arrs), as the /data used by this Docker image to store the config files is hard coded in the script and collides with the /data used for the media. I'll make an option to make it overridable later.

@mrusse
Copy link
Owner

mrusse commented Jan 7, 2025

Not sure what you mean about how it collides with anything. "/data" is only an internal mount within Soularrs container. Not sure how it could collide with anything since the only other mount is the one for Slskd the slskd downloads folder which you can set to whatever you want. Also this is clearly explained in the readme.

volumes:
      #"You can set /downloads to whatever you want but will then need to change the Slskd download dir in your config file"
      - /path/to/slskd/downloads:/downloads
      #Select where you are storing your config file.
      #Leave "/data" since thats where the script expects the config file to be
      - /path/to/config/dir:/data

@tubededentifrice
Copy link
Contributor

Sorry, let me clarify: you need to mount the slskd directory onto Soularr, and it's very common for this directory to be within /data; which conflicts with the second volume storing the config etc., which is hard coded to be /data there: https://github.com/mrusse/soularr/blob/main/soularr.py#L555-L557
(see trash guides over there: https://trash-guides.info/File-and-Folder-Structure/ )

Eg. my slskd download directory would be everywhere at /data/slskd/downloads ; my music after import into /data/media/music and so on so forth

Those config should have been into /config to stay within the norm, but it's very hard to change now there is active installs; so instead, let's make that overridable by adding some args to the script.

@tubededentifrice
Copy link
Contributor

(from what I understand from the script, it will be problematic if the download directory is not mounted at the same location between Lidarr and Soularr)

@JPDVM2014
Copy link
Author

JPDVM2014 commented Jan 7, 2025

I use Trash's guides on unraid and haven't had an issue with the /data colliding, but I'm going through my config to make sure I didn't account for it without realizing.

I think the easiest way to deal with it would probably be to add a mount to lidarr and slskd without the /data. Keeping all other mounts as-is.

ex. Slskd: /mnt/user/data/slskd/downloads : /downloads

Lidarr: /mnt/user/data/slskd/downloads : /slskd

EDIT: Turns out I did that without even realizing it. I'll add it to my readme for the template.

@mrusse
Copy link
Owner

mrusse commented Jan 7, 2025

They are only talking about the two mounts within Soularr. They are saying that they will collide if they are both set to /data... Which yes of course they will. There are no issues as long as you don't use /data to mount the slskd downloads dir to. Although if you do want to follow that standard then an override for the config dir will help. Btw @tubededentifrice this really has nothing to do with unraid so it should not be in this thread.

@JPDVM2014
Copy link
Author

(from what I understand from the script, it will be problematic if the download directory is not mounted at the same location between Lidarr and Soularr)

I have Lidarr and Soularr with different mount points. Lidarr is at /slskd, soularr is at /downloads. Seems to work fine as long as the config.ini is correct.

@mrusse
Copy link
Owner

mrusse commented Jan 7, 2025

(from what I understand from the script, it will be problematic if the download directory is not mounted at the same location between Lidarr and Soularr)

I have Lidarr and Soularr with different mount points. Lidarr is at /slskd, soularr is at /downloads. Seems to work fine as long as the config.ini is correct.

Gotcha seemed to have missed that. But yes it does not matter if they are different between the containers. You just have to specify in the config files. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants