Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to capture non-fatal errors and potentially make them fatal #3

Open
jfischer opened this issue Aug 5, 2017 · 0 comments

Comments

@jfischer
Copy link
Contributor

jfischer commented Aug 5, 2017

Borrowing from RxPython, ThingFlow provides an on_error() interface for input things and filters. If a non-fatal error occurs, the associated thing should catch the error, print it out, pass it downstream using _dispatch_error() and then close the downstream connections. See IterableAsOutputThing for an example.

The problem with this approach is that errors just end up on standard output and operation continues (assuming there still is something to run). Ideally, we'd want to have a standard error handler for non-fatal errors (that just prints it as default) and some way of making non-fatal errors fatal. This is challenging, since the "things" don't have any access to the scheduler's state (the natural place to put this error handler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant