Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #10

Closed
davehunt opened this issue May 23, 2012 · 3 comments
Closed

Add tests #10

davehunt opened this issue May 23, 2012 · 3 comments
Milestone
1.9

Comments

@davehunt
Copy link
Member

No description provided.

@whimboo
Copy link
Contributor

whimboo commented May 23, 2012

Necessary but I would wait until we have solved issue #7.

@davehunt
Copy link
Member Author

See pull #95

Nebelhom pushed a commit to Nebelhom/mozdownload that referenced this issue Aug 20, 2013
@davehunt @Nebelhom
Issue mozilla#10 (Part 1): Implemented first tests and virtual enviro…
3e32359 
…nment
Nebelhom added a commit to Nebelhom/mozdownload that referenced this issue Aug 20, 2013
@Nebelhom
Issue mozilla#10 (Part 1): Implemented first tests and virtual enviro…
a666e41 
…nment
Nebelhom added a commit to Nebelhom/mozdownload that referenced this issue Aug 20, 2013
@Nebelhom
Summary of Changes (Issue mozilla#10)
48cb77b 
Merge remote-tracking branches 'origin/master' and 'upstream/master'

Bump mozinfo dependancy to 0.4

The first test!

added venv_test.sh to the code - Courtesy davehunt

made the code pep8 compliant and put inline comments above line - We don't like inline comments... apparently

test if url is correctly passed to DirectScraper

Changed README and adjusted docstring of test.py

Adjusted according to review comments

Added mozdownload_venv to .gitignore

Minor changes

renaming of test class and method + remove explicit definition of python path when calling venv_test.sh

changed call to python interpreter inline in venv_test.sh

Changed directory structure and adjusted run_tests.sh pip install call. mozinfo version upgrade to 0.6

Changed README.md to reflect change of filename

Small minor changes and adjustments

More minor adjustments

small change in README
davehunt pushed a commit to davehunt/mozdownload that referenced this issue Aug 20, 2013
@Nebelhom @davehunt
Added test harness and first test (mozilla#10)
ab22bfe
@davehunt
Copy link
Member Author

We have tests! ab22bfe

Nebelhom added a commit to Nebelhom/mozdownload that referenced this issue Aug 20, 2013
@Nebelhom
Added test harness and first test (mozilla#10)
5bdcfb9
@whimboo whimboo mentioned this issue Aug 27, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
2 participants
@davehunt @whimboo