Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code_review] Add example of unwanted "Ensure ..." comments to the filtering phase #4431

Open
marco-c opened this issue Aug 20, 2024 · 2 comments
Assignees

Comments

@marco-c
Copy link
Collaborator

marco-c commented Aug 20, 2024

We have noticed this type of comment is either ignored or marked as invalid by users. We should filter it out.

@suhaibmujahid
Copy link
Member

Examples:

  • The test setup correctly sets the hasUserNamespaces property to false and resets it after the test. Ensure that the test accounts for both dark and light themes when checking for the expected background color.
  • The new conditional check for aFlags before calling InitResizeFlags introduces a new behavior where resize flags may not be initialized in some cases. Ensure that all code paths setting aFlags are reviewed to confirm that this behavior is intentional and correctly implemented.

@marco-c
Copy link
Collaborator Author

marco-c commented Nov 14, 2024

This should be covered by #4579. We should test after that one is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants