Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched bug number and crash signature #4144

Open
hsinyi opened this issue Apr 17, 2024 · 3 comments
Open

Mismatched bug number and crash signature #4144

hsinyi opened this issue Apr 17, 2024 · 3 comments

Comments

@hsinyi
Copy link

hsinyi commented Apr 17, 2024

In Quality report for DOM Core, the bug number associated for the crash signature "mozilla::RestyleManager::ElementStateChanged" is wrong. The bug in the quality report is Bug 1651070 - doesn't deal with dynamic lang changes correctly., which is no longer true. The crash signature was removed from Bug 1651070, and the bug 1793410 is instead associated with that signature , which is also the bug in https://crash-stats.mozilla.org

@marco-c
Copy link
Collaborator

marco-c commented May 4, 2024

The quality report script is getting the data from https://mozilla.github.io/stab-crashes/nightly.json, which has bug 1651070 in the list.
We'll need to debug this in https://github.com/mozilla/stab-crashes.

@marco-c
Copy link
Collaborator

marco-c commented May 4, 2024

Ah, I know the reason.
The script in https://github.com/mozilla/stab-crashes is considering all signatures associated to duplicated bugs as also belonging to the bug targeted by the duplication.

In this case, https://bugzilla.mozilla.org/show_bug.cgi?id=1804806 is marked as duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1651070. https://bugzilla.mozilla.org/show_bug.cgi?id=1804806 has "mozilla::RestyleManager::ElementStateChanged", and so the script assumes "mozilla::RestyleManager::ElementStateChanged" is also associated with https://bugzilla.mozilla.org/show_bug.cgi?id=1651070.

@marco-c
Copy link
Collaborator

marco-c commented May 4, 2024

So in practice this is "by design". We could drop this rule, but then we'd risk missing some cases where a signature hasn't been copied from a duplicate to the target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants