Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the logic in the bug_to_types function and extract it from the bugtype model file #3900

Closed
suhaibmujahid opened this issue Dec 6, 2023 · 0 comments · Fixed by #3907
Assignees

Comments

@suhaibmujahid
Copy link
Member

The logic in bug_to_types could be refactored to better fit our use case. These are the main points:

  • It would be best to avoid creating models that depend on each other. If there is a need to modify the logic in the bugtype model, it might not be apparent that other models will be affected. Therefore, it is better to keep the common logic separate from the model file.
  • We don't need to check all types in this case, just the performance type. So, we can split the function and only use the part that detects if the bug is related to performance.

Originally posted by @suhaibmujahid in #3895 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants