Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with logging-fstring-interpolation / W1203 #3820

Closed
suhaibmujahid opened this issue Nov 19, 2023 · 2 comments · Fixed by #3822
Closed

Comply with logging-fstring-interpolation / W1203 #3820

suhaibmujahid opened this issue Nov 19, 2023 · 2 comments · Fixed by #3822
Labels
good-first-bug Good for newcomers

Comments

@suhaibmujahid
Copy link
Member

Some logging statements aren't complying with logging-fstring-interpolation / W1203.

Examples:

logger.info(
f"{sum(1 for label in classes.values() if label == 1)} issues belong to Firefox"
)
logger.info(
f"{sum(1 for label in classes.values() if label == 0)} issues do not belong to Firefox"

logger.info(
f"Already classified {len(prev_bug_introducing_commits)} commits..."
)

@suhaibmujahid suhaibmujahid added the good-first-bug Good for newcomers label Nov 19, 2023
@sreeroo
Copy link
Contributor

sreeroo commented Nov 20, 2023

Hello, can I please work on this issue ?

@suhaibmujahid
Copy link
Member Author

@sreeroop10 thank you for your interest! Unfortunately, the Issue already has an open pull request to address it. The issue will be available again only if the pull request gets closed without being merged.

Feel free to choose any other issue. The ones with the good-first-bug label are a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-bug Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants