Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLinkModelNamesWithCollisionGeometry() does not include base_link of robot #2325

Closed
MarqRazz opened this issue Aug 23, 2023 · 2 comments · Fixed by #2660
Closed

getLinkModelNamesWithCollisionGeometry() does not include base_link of robot #2325

MarqRazz opened this issue Aug 23, 2023 · 2 comments · Fixed by #2660
Assignees
Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.

Comments

@MarqRazz
Copy link
Contributor

Description

I am working on a robot that includes a linear actuator at the base of a UR5. When testing a pick and place MTC task I noticed that I was getting plans that included collision between the base_link of the linear actuator group and my attached collision object.
collision_issue

In my robots srdf file I have the following groups included to allow motion planning with the arm + actuator at the same time:

    <group name="linear_actuator">
        <chain base_link="linear_actuator_base_link" tip_link="linear_actuator_carriage_link"/>
    </group>
    <group name="manipulator">
        <chain base_link="base_link" tip_link="tool0"/>
    </group>
    <group name="linear_actuator_and_manipulator">
        <group name="linear_actuator" />
        <group name="manipulator" />        
    </group>

In my MTC task I am getting the collision links of the motion planning group to allow and exclude collision between different groups with the following function:

const auto& manipulator_group_collision_link_model_names = task
                                                    ->getRobotModel()
                                                    ->getJointModelGroup("linear_actuator_and_manipulator")
                                                    ->getLinkModelNamesWithCollisionGeometry();

But when I inspect this list the linear_actuator_base_link is not part of it.

Links with Collision Geometry: [linear_actuator_carriage_link, base_link_inertia, shoulder_link, upper_arm_link, forearm_link, wrist_1_link, wrist_2_link, wrist_3_link]

Debugging the construction of the group I noticed that all base_links of a group are not included in the JointModelGroup. This kinda makes sense because the base is not a joint but the pair of links that make the first joint should include it's collision geometry.

@MarqRazz MarqRazz added the bug Something isn't working label Aug 23, 2023
@MarqRazz MarqRazz self-assigned this Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Oct 9, 2023
Copy link

This issue was closed because it has been stalled for 45 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Nov 24, 2023
@MarqRazz MarqRazz reopened this Jan 24, 2024
@MarqRazz MarqRazz moved this from ✅ Done to 👀 In review in MoveIt Jan 24, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Jan 25, 2024
@sjahr sjahr linked a pull request Jan 25, 2024 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in MoveIt Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants